fix(core): classifier gaps for issue #201 builder split#206
Merged
Conversation
Extract serve_pipeline from run.rs so all run* entrypoints share one orchestration path. Add file-scope --lib run_with_shutdown tests that mirror the pre-existing integration harness. Move extract tests to tests/extract.rs and fix non-shutdown HTTP/3/dual-stack entrypoints so on_shutdown hooks are not taken and dropped on pending delegates.
- Merge serve_pipeline into run.rs; all run* entrypoints run on_shutdown hooks - Remove new run_with_shutdown lib tests; restore pre-existing hot_reload unit test - Move router/extract test bodies to tests/support/*_lib.rs via include! - Delete src/router/tests/ directory and serve_pipeline.rs module Verification: 226 lib tests pass (x2), all src/**/*.rs < 50KB, integration run coverage preserved
Owner
Author
|
Round-4 classifier gaps addressed in \cd84443. CI green on latest push. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final classifier round-4 fixes for issue #201 (builder split).
un.rs\ (4 app modules only: routing / openapi / health / run)
un*\ entrypoints now take and run \on_shutdown\ hooks after the server exits
un_with_shutdown_*\ lib tests added in prior round; run paths stay covered by pre-existing integration tests (\health_endpoints, \status_page, \production_defaults,
esponse_streaming, \http3_run_dev)
Verification
esponse_streaming\ (1), \http3_run_dev\ (1)
Closes classifier blockers for goal #201. Enables PR #200 checklist item (builder.rs split).